CareUI: Adds a higher-order Form component (not used anywhere)
#4633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
❌ Deploy Preview for care-net failed.
|
github-actions
bot
added
the
cypress failed
|
Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions. |
rithviknishad
added
work-in-progress
and removed
stale
cypress failed
|
👋 Hi, @rithviknishad, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
rithviknishad
changed the title
Form componentForm component (for Facility Create Page)
|
SonarCloud Quality Gate failed.
|
github-actions
bot
added
the
cypress failed
rithviknishad
removed
Deploy-Failed
rithviknishad
changed the title
Form component (for Facility Create Page)Form component (not used anywhere)
khavinshankar
approved these changes
Feb 3, 2023
rabilrbl
pushed a commit
that referenced
this pull request
Feb 6, 2023
* remove `reducerProps` to make things simpler * Implements `Form` HOC and `FormContext` * removes unused reducer props from search input * RequiredFieldValidator to support custom message * consume form context and resolve props internally * rename 'props' to 'field' to strictly break if incorrect migration * migrate existing fields * fix month form field
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
reducerPropsfromFormFieldBasePropsto simplify the potentially complex and confusing component API interface.Formcomponent to abstract away the form state handling logic.@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist