Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved UI of investigations, procedures, PRN prescription and prescription #4639

Merged
merged 3 commits into from
Feb 3, 2023
Merged

Improved UI of investigations, procedures, PRN prescription and prescription #4639

merged 3 commits into from
Feb 3, 2023

Conversation

GokulramGHV
Copy link
Member

Proposed Changes

Screenshots

image

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@GokulramGHV GokulramGHV requested a review from a team January 19, 2023 18:12
@GokulramGHV GokulramGHV requested a review from a team as a code owner January 19, 2023 18:12
@vercel
Copy link

vercel bot commented Jan 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 26, 2023 at 3:48AM (UTC)

@netlify
Copy link

netlify bot commented Jan 19, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ff83384
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63d1f754e1b472000ac5db02
😎 Deploy Preview https://deploy-preview-4639--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 23, 2023
@github-actions
Copy link

👋 Hi, @GokulramGHV,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

1 similar comment
@github-actions
Copy link

👋 Hi, @GokulramGHV,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

@GokulramGHV @khavinshankar
image

the UI is working fine, get it UI approved in todays EOD, @GokulramGHV work on merge conflict

@GokulramGHV GokulramGHV removed the merge conflict pull requests with merge conflict label Jan 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 26, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
10.9% 10.9% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit aca7845 into coronasafe:develop Feb 3, 2023
rabilrbl pushed a commit that referenced this pull request Feb 6, 2023
@GokulramGHV @rabilrbl
Improved UI of investigations, procedures, PRN prescription and presc…
d2b3f35 
…ription (#4639)

* Improved Procedures UI

* Improved Investigations and Prescriptions UI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

UI of investigations, procedures, PRN prescription and prescription
3 participants
@GokulramGHV @nihal467 @khavinshankar