Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set max limit for bed capacity occupied input #4651

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Set max limit for bed capacity occupied input #4651

merged 3 commits into from
Feb 2, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team January 21, 2023 05:46
@rithviknishad rithviknishad requested a review from a team as a code owner January 21, 2023 05:46
@netlify
Copy link

netlify bot commented Jan 21, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 2cc4ca9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63d3c55e8e6a2e0009918739
😎 Deploy Preview https://deploy-preview-4651--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Jan 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 0:39AM (UTC)

@nihal467
Copy link
Member

@rithviknishad
image

the alignment is not proper in your PR

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 27, 2023
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@rithviknishad rithviknishad added needs testing and removed test failed merge conflict pull requests with merge conflict labels Jan 27, 2023
@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.3% 4.3% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b6780bb into coronasafe:develop Feb 2, 2023
rabilrbl pushed a commit that referenced this pull request Feb 6, 2023
@rithviknishad @rabilrbl
Set max limit for bed capacity occupied input (#4651)
9d8d2fc 
* fix #4647

* fix styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bed capacity occupied field allowing input above total capacity
3 participants
@rithviknishad @nihal467 @khavinshankar