Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made User card same in filter users in the facility page #4663

Closed
wants to merge 4 commits into from
Closed

Made User card same in filter users in the facility page #4663

wants to merge 4 commits into from

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Jan 23, 2023 •
edited
Loading

Proposed Changes

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team January 23, 2023 17:44
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner January 23, 2023 17:44
@vercel
Copy link

vercel bot commented Jan 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 27, 2023 at 8:35AM (UTC)

@netlify
Copy link

netlify bot commented Jan 23, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit f61fa61
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63d38c26dfa85900089b7432
😎 Deploy Preview https://deploy-preview-4663--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Jan 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 4 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Jan 27, 2023
@github-actions
Copy link

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented Feb 2, 2023

@patelaryan7751 check the merge conflict

@nihal467
Copy link
Member

nihal467 commented Feb 7, 2023

@patelaryan7751 clear the merge conflict @khavinshankar review it

@nihal467
Copy link
Member

@patelaryan7751 clear the merge conflict

@patelaryan7751
Copy link
Contributor Author

closing this working on a new PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
merge conflict pull requests with merge conflict needs review needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User card is different when we filter users in the facility page
2 participants
@patelaryan7751 @nihal467