Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ESLint: warnings for string literals that aren't translated #4750

Merged
merged 5 commits into from
Feb 28, 2023
Merged

ESLint: warnings for string literals that aren't translated #4750

merged 5 commits into from
Feb 28, 2023

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Feb 5, 2023 •
edited
Loading

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel
Copy link

vercel bot commented Feb 5, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 28, 2023 at 6:21AM (UTC)

@netlify
Copy link

netlify bot commented Feb 5, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 496e859
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63fd9d0646846c00080900c1
😎 Deploy Preview https://deploy-preview-4750--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad changed the title setup warnings for literals with i18next and errors to validate locale keys ESLint: warnings for string literals that aren't translated, errors for invalid locale keys Feb 5, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Feb 5, 2023
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added stale merge conflict pull requests with merge conflict labels Feb 12, 2023
@github-actions
Copy link

👋 Hi, @rithviknishad,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the stale label Feb 15, 2023
@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added stale and removed stale labels Feb 23, 2023
@rithviknishad rithviknishad removed merge conflict pull requests with merge conflict cypress failed pull request with cypress test failure labels Feb 28, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Feb 28, 2023
@rithviknishad rithviknishad added needs review and removed cypress failed pull request with cypress test failure labels Feb 28, 2023
@rithviknishad rithviknishad changed the title ESLint: warnings for string literals that aren't translated, errors for invalid locale keys ESLint: warnings for string literals that aren't translated Feb 28, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 28, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad rithviknishad marked this pull request as ready for review February 28, 2023 06:20
@rithviknishad rithviknishad requested a review from a team February 28, 2023 06:20
@rithviknishad rithviknishad requested a review from a team as a code owner February 28, 2023 06:20
@rithviknishad
Copy link
Member Author

@khavinshankar unable to use a single file locales yaml. Will open an issue regd. it. Let the warnings be merged for now.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Feb 28, 2023
@khavinshankar khavinshankar merged commit f604269 into develop Feb 28, 2023
@rithviknishad rithviknishad deleted the eslint-i18 branch July 26, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure needs review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup eslint plugins to aid in handling localizations
2 participants
@rithviknishad @khavinshankar