Fixed facility cover photo #4765
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@GokulramGHV The card height is irregular for different facilities now |
|
Kudos, SonarCloud Quality Gate passed!
|
|
the existing staging card size looks good, rather than the size in the deploy preview, can we keep it that way? |
| @@ -47,7 +47,7 @@ export const FacilityCard = (props: { facility: any; userType: any }) => { | |||
|
|
|||
| return ( | |||
| <div key={`usr_${facility.id}`} className="w-full"> | |||
| <div className="block rounded-lg h-full overflow-clip bg-white shadow hover:border-primary-500"> | |||
| <div className="block rounded-lg h-64 overflow-clip bg-white shadow hover:border-primary-500"> | |||
There was a problem hiding this comment.
| <div className="block rounded-lg h-64 overflow-clip bg-white shadow hover:border-primary-500"> | |
| <div className="block rounded-lg h-full overflow-clip bg-white shadow hover:border-primary-500"> |
There was a problem hiding this comment.
@rithviknishad making this change makes the facility cards' heights not uniform as @Pranshu1902 mentioned above
| @@ -57,7 +57,7 @@ export const FacilityCard = (props: { facility: any; userType: any }) => { | |||
| <img | |||
| src={facility.read_cover_image_url} | |||
| alt={facility.name} | |||
| className="w-full h-[210px] object-cover" | |||
| className="object-cover w-full h-full" | |||
There was a problem hiding this comment.
| className="object-cover w-full h-full" | |
| className="object-cover h-full" |
nihal467
added
work-in-progress
and removed
question
|
@GokulramGHV once you make the changes, mark it for testing |
|
@nihal467 as this pr was discussed with gigin, he apporved the changes and asked me to mark it for testing |
|
LGTM |
|
@rithviknishad can you rereview this |
Proposed Changes
Screenshot
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist