Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict Add skills button to DistrictAdmin #4767

Merged
merged 2 commits into from
Feb 5, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Feb 5, 2023

Fixes #4763

Allowed:
image

Disallowed:
PerfectIberiannase

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team February 5, 2023 16:08
@Ashesh3 Ashesh3 requested a review from a team as a code owner February 5, 2023 16:08
@Ashesh3 Ashesh3 requested a review from bodhish February 5, 2023 16:08
@vercel
Copy link

vercel bot commented Feb 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 5, 2023 at 4:38PM (UTC)

@netlify
Copy link

netlify bot commented Feb 5, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 47a8988
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63dfdaeb87cf6f0008fbc4ca
😎 Deploy Preview https://deploy-preview-4767--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ashesh3 Ashesh3 added the P1 breaking issue or vital feature label Feb 5, 2023
@nihal467
Copy link
Member

nihal467 commented Feb 5, 2023

@Ashesh3
image

state-admin are not able to add skill, as per issue, district admin and above should be able to add skills

@Ashesh3
Copy link
Member Author

Ashesh3 commented Feb 5, 2023

@Ashesh3 image

state-admin are not able to add skill, as per issue, district admin and above should be able to add skills

Fixed

@sonarcloud
Copy link

sonarcloud bot commented Feb 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@nihal467
Copy link
Member

nihal467 commented Feb 5, 2023

LGTM

@khavinshankar khavinshankar merged commit 4c3667c into coronasafe:develop Feb 5, 2023
rabilrbl pushed a commit that referenced this pull request Feb 6, 2023
* Restrict Add skills button to DistrictAdmin

* Allow StateAdmin
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 breaking issue or vital feature tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Skill Add button for all user below the district admin
3 participants