Made the user add button consistent with others #4771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@nihal467 @rithviknishad if you like this UI update please merge this. |
rithviknishad
approved these changes
Feb 6, 2023
There was a problem hiding this comment.
@siva-balan could you use ButtonV2 so that we have consistent design?
|
@rithviknishad please re-review this and change the label. |
rithviknishad
approved these changes
Feb 7, 2023
|
in the normal view and the responsive view, add user button width needs to increase similar to the advanced filter button to maintain the consistency
|
siva-balan
requested review from
rithviknishad
and removed request for
vigneshhari
|
@nihal467 the update for the view is done. please check |
rithviknishad
approved these changes
Feb 9, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
LGTM |
khavinshankar
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Made the user add button consistent with others
Before:
After:
Made the new user add button consistent with other page buttons like create assets etc, to give it a neat look and to reduce unnecessary space.
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist