Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add updated symptopms to DailyRound #4784

Merged
merged 2 commits into from
Feb 8, 2023
Merged

Add updated symptopms to DailyRound #4784

merged 2 commits into from
Feb 8, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Feb 7, 2023

Fixes #4783

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 added needs testing P1 breaking issue or vital feature labels Feb 7, 2023
@Ashesh3 Ashesh3 requested a review from a team February 7, 2023 10:42
@Ashesh3 Ashesh3 requested a review from a team as a code owner February 7, 2023 10:42
@Ashesh3 Ashesh3 requested a review from bodhish February 7, 2023 10:42
@vercel
Copy link

vercel bot commented Feb 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 7, 2023 at 1:40PM (UTC)

@netlify
Copy link

netlify bot commented Feb 7, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 68960f5
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63e2542271f63d0008bae307
😎 Deploy Preview https://deploy-preview-4784--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Feb 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.9% 2.9% Duplication

@nihal467
Copy link
Member

nihal467 commented Feb 7, 2023

@Ashesh3
image
image

  • when I am trying to update an existing log, I can see extra badges are present inside the symptoms

image

  • when I am trying to select a sari, it is showing error

image

  • when I am selecting sore throat, cough and breathlessness, during the updation, it is showing something went wrong error

@Ashesh3
Copy link
Member Author

Ashesh3 commented Feb 7, 2023

Waiting for ohcnetwork/care#1181

@nihal467
Copy link
Member

nihal467 commented Feb 8, 2023

LGTM

@khavinshankar khavinshankar merged commit 02ce3d5 into ohcnetwork:develop Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@Pranshu1902 Pranshu1902 Pranshu1902 approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update log view detail button is crashing
4 participants
@Ashesh3 @nihal467 @khavinshankar @Pranshu1902