Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled Proceed button of Edit File Name #4791

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Disabled Proceed button of Edit File Name #4791

merged 3 commits into from
Feb 14, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Feb 8, 2023 •
edited
Loading

Fixes #4790
Disabled the Proceed button on Edit File name number View Sample report if the file name is same.
image

@Pranshu1902 Pranshu1902 requested a review from a team February 8, 2023 13:18
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner February 8, 2023 13:18
@vercel
Copy link

vercel bot commented Feb 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 13, 2023 at 9:41AM (UTC)

@netlify
Copy link

netlify bot commented Feb 8, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b42288e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63ea05296260f700080d7bec
😎 Deploy Preview https://deploy-preview-4791--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

LGTM

khavinshankar
khavinshankar reviewed Feb 13, 2023
View reviewed changes
Copy link
Member

@khavinshankar khavinshankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but also do the same if there is no text i.e., name.length === 0

@Pranshu1902
Copy link
Contributor Author

@khavinshankar done

@sonarcloud
Copy link

sonarcloud bot commented Feb 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 8562a53 into ohcnetwork:develop Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
good to merge tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disable Proceed button of edit file name popup for same name
3 participants
@Pranshu1902 @nihal467 @khavinshankar