Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Enhancement of the patient doctor connect #4819

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Feb 14, 2023

Bug Fix

Proposed Changes

  • Added Voice and WhatsApp call options
  • Removed doctor qualifications from connect feature
  • Added a clipboard to copy the phone number

Associated Issue

Screenshot

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team February 14, 2023 14:15
@aeswibon aeswibon requested a review from a team as a code owner February 14, 2023 14:15
@vercel
Copy link

vercel bot commented Feb 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 11:23AM (UTC)

@netlify
Copy link

netlify bot commented Feb 14, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e9b0fc0
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63f4a8c3f60cf00008fb39dd
😎 Deploy Preview https://deploy-preview-4819--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Feb 20, 2023

@cp-coder

https://deploy-preview-4819--care-net.netlify.app/facility/2797dc82-4216-47fa-969b-47f02019b6ca/patient/124b749e-8c86-4d3e-8631-53f66a4926f1/consultation/e6acf370-4dce-443e-b4be-9b9198b64cbc

image

marking it for discussion for discussing following points

  • icon size is really call
  • add a tooltip to the icons
  • Currently, the card is not clickable, will it be a problem for the user, since going towards a small call icon and clicking, it doesn't feel like a good experience? I believe, along with the icons any card should be clickable, and we should be redirected to whatsapp calls.

@aparnacoronasafe
Copy link
Member

lets discuss in EOD

@nihal467
Copy link
Member

nihal467 commented Feb 20, 2023

@cp-coder after the EOD, change the following ASAP

  • make the icons bigger
  • add a tooltip to the icon
  • when someone clicks anywhere in the card, similar to the existing staging, by default, WhatsApp redirection should work

@nihal467
Copy link
Member

@cp-coder
image

the copy button is not working

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 3e8c482 into ohcnetwork:develop Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement of the patient doctor connect
5 participants