Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to Home facility management #4838

Merged
merged 2 commits into from
Feb 22, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Feb 16, 2023

Fixes #4820

  • Made Home Facility an optional field while creating a user
  • Added option to clear Home Facility of a user.

SomeJanenschia

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team February 16, 2023 18:07
@Ashesh3 Ashesh3 requested a review from a team as a code owner February 16, 2023 18:07
@netlify
Copy link

netlify bot commented Feb 16, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit d429a37
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63f44db23e7b9d0008820bf6
😎 Deploy Preview https://deploy-preview-4838--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 21, 2023 at 4:53AM (UTC)

@nihal467
Copy link
Member

nihal467 commented Feb 21, 2023

@Ashesh3
image

I logged in as a staff user id, and I can unlink the home facility of other user ids, who are staff. can you get it fixed ASAP?

@sonarcloud
Copy link

sonarcloud bot commented Feb 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
2.6% 2.6% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 6f81561 into coronasafe:develop Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Home Facility Assignment for Doctors
3 participants