Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bottom-align-description #4841

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Bottom-align-description #4841

merged 2 commits into from
Feb 27, 2023

Conversation

siva-balan
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@siva-balan siva-balan requested a review from a team February 18, 2023 04:56
@siva-balan siva-balan requested a review from a team as a code owner February 18, 2023 04:56
@vercel
Copy link

vercel bot commented Feb 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 27, 2023 at 6:49AM (UTC)

@netlify
Copy link

netlify bot commented Feb 18, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 87680f2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63fc51e4804da700082a44ca
😎 Deploy Preview https://deploy-preview-4841--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Pranshu1902
Copy link
Contributor

@siva-balan The Icon and Goal content are overlapping on 14 inch screen
image

@Pranshu1902
Copy link
Contributor

@siva-balan Any update on the PR?

@siva-balan
Copy link
Contributor Author

@siva-balan Any update on the PR?

Sry, I will push it by today

@sonarcloud
Copy link

sonarcloud bot commented Feb 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@siva-balan
Copy link
Contributor Author

siva-balan commented Feb 27, 2023 •
edited
Loading

Is this UI fix okay? @nihal467 @Pranshu1902
image

@Pranshu1902
Copy link
Contributor

@siva-balan Yes, it's good

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 1892963 into coronasafe:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@Pranshu1902 Pranshu1902 Pranshu1902 approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bottom align description in the auth layout
5 participants
@siva-balan @Pranshu1902 @nihal467 @rithviknishad @khavinshankar