Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: badges are malfunctioning in patient tab #4848

Merged
merged 1 commit into from
Feb 21, 2023
Merged

fix: badges are malfunctioning in patient tab #4848

merged 1 commit into from
Feb 21, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Feb 20, 2023 •
edited
Loading

Bug Fix

Proposed Changes

  • Properly aligned Bed Type badge
  • Reset the Phone Number and Emergency Phone Number boxes on removing the filter badge
  • Enable removal of the Bed Type badge

Associated Issue

Screenshot

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team February 20, 2023 10:12
@aeswibon aeswibon requested a review from a team as a code owner February 20, 2023 10:12
@vercel
Copy link

vercel bot commented Feb 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 20, 2023 at 10:15AM (UTC)

@sonarcloud
Copy link

sonarcloud bot commented Feb 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@netlify
Copy link

netlify bot commented Feb 20, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 8db46b9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63f347a7a499c40008277179
😎 Deploy Preview https://deploy-preview-4848--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 1a837ee into coronasafe:develop Feb 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
P2 tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug : Badges are malfunctioning in patient tab
4 participants
@aeswibon @nihal467 @rithviknishad @khavinshankar