Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scoll date range select into view when export is clicked in Patients Page #4854

Merged
merged 2 commits into from
Feb 27, 2023
Merged

Scoll date range select into view when export is clicked in Patients Page #4854

merged 2 commits into from
Feb 27, 2023

Conversation

GokulramGHV
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@GokulramGHV GokulramGHV requested a review from a team February 21, 2023 02:51
@GokulramGHV GokulramGHV requested a review from a team as a code owner February 21, 2023 02:51
@vercel
Copy link

vercel bot commented Feb 21, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 24, 2023 at 3:12PM (UTC)

@netlify
Copy link

netlify bot commented Feb 21, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7761e16
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63f8d371e4f96d0008009199
😎 Deploy Preview https://deploy-preview-4854--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Feb 21, 2023 •
edited by GokulramGHV
Loading

@GokulramGHV
image
image

  • the page is stretched horizontally in your PR, get it fixed ASAP
  • can you make the sort by uniform size like others to ensure consistency
  • change the notification color from yellow to red for ensuring consistency with other error notification

@sonarcloud
Copy link

sonarcloud bot commented Feb 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit a2b8174 into coronasafe:develop Feb 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@Pranshu1902 Pranshu1902 Pranshu1902 approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add a dropdown to select dates for Patient export options
4 participants
@GokulramGHV @nihal467 @khavinshankar @Pranshu1902