Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating advanced filter fields #4892

Merged
merged 1 commit into from
Feb 27, 2023
Merged

Updating advanced filter fields #4892

merged 1 commit into from
Feb 27, 2023

Conversation

jeromtom
Copy link
Contributor

Proposed Changes

  • Fixes advanced filter on patient list- renaming fields #4887

  • edit "Disease status" to "COVID Disease status"

  • edit "Vaccinated" to "Vaccinated against COVID"

  • edit "Date of result" to "Date of COVID test result"

  • edit "Date declared positive" to "Date declared COVID positive"

  • edit "Vaccination Date" to "COVID Vaccination Date"

  • edit "Created date" to "Registration Date"

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@jeromtom jeromtom requested a review from a team February 25, 2023 22:37
@jeromtom jeromtom requested a review from a team as a code owner February 25, 2023 22:37
@vercel
Copy link

vercel bot commented Feb 25, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 25, 2023 at 10:39PM (UTC)

@netlify
Copy link

netlify bot commented Feb 25, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 59ba9a2
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/63fa8dbac4de6d00087289f1
😎 Deploy Preview https://deploy-preview-4892--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit db2ade8 into coronasafe:develop Feb 27, 2023
@jeromtom jeromtom deleted the #4887 branch February 27, 2023 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

advanced filter on patient list- renaming fields
4 participants
@jeromtom @nihal467 @rithviknishad @khavinshankar