Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes incorrect validation check for asset warranty expiry #5028

Merged
merged 1 commit into from
Mar 2, 2023
Merged

Fixes incorrect validation check for asset warranty expiry #5028

merged 1 commit into from
Mar 2, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team March 2, 2023 07:39
@rithviknishad rithviknishad requested a review from a team as a code owner March 2, 2023 07:39
@vercel
Copy link

vercel bot commented Mar 2, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 2, 2023 at 7:42AM (UTC)

@netlify
Copy link

netlify bot commented Mar 2, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 7b60b63
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/640052cf53c7fc00078c6bd3
😎 Deploy Preview https://deploy-preview-5028--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Mar 2, 2023
@rithviknishad rithviknishad added needs testing urgent P1 breaking issue or vital feature and removed cypress failed pull request with cypress test failure labels Mar 2, 2023
@nihal467
Copy link
Member

nihal467 commented Mar 2, 2023

LGTM

@khavinshankar khavinshankar merged commit 2dca6e7 into develop Mar 2, 2023
@rithviknishad rithviknishad deleted the fix-5027 branch July 26, 2023 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to give warranty expiry in asset creation page
3 participants
@rithviknishad @nihal467 @khavinshankar