Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added "Procedures" in Patient Dashboard. #5034

Conversation

jeromtom
Copy link
Contributor

@jeromtom jeromtom commented Mar 3, 2023

Proposed Changes

  • Fixes View procedures in Patient Dashboard #4871
  • Add a card in the Patient Dashboard below "General Instructions" to show additional details about each of the procedures suggested keeping the design consistent with the "Body Details" card.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@vercel
Copy link

vercel bot commented Mar 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 11, 2023 at 0:14AM (UTC)

@netlify
Copy link

netlify bot commented Mar 3, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 450d878
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/640c704191fe3800089bb10e
😎 Deploy Preview https://deploy-preview-5034--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@jeromtom jeromtom changed the title Fix using Body Details clone Added "Procedures" in Patient Dashboard. Mar 3, 2023
@jeromtom jeromtom marked this pull request as ready for review March 3, 2023 09:14
@jeromtom jeromtom requested a review from a team March 3, 2023 09:14
@jeromtom jeromtom requested a review from a team as a code owner March 3, 2023 09:14
@jeromtom jeromtom requested a review from bodhish March 3, 2023 09:14
@jeromtom
Copy link
Contributor Author

jeromtom commented Mar 3, 2023

Cypress Tests are failing as usual. Let me know if any other change is required.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromtom
Copy link
Contributor Author

jeromtom commented Mar 5, 2023

@rithviknishad , understood will work on it. Do we have to show the "Repetitive" field? How about showing either "Time" or "Frequency" depending on if repetitive field was selected.

@rithviknishad
Copy link
Member

@jeromtom I agree with that.

cc: @aparnacoronasafe

@sonarcloud
Copy link

sonarcloud bot commented Mar 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
16.6% 16.6% Duplication

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jeromtom I'm still not able to do a horizontal scroll, nor contents visible.

How about using col-span-2 scroll-x-auto?

image

Comment on lines +16 to +29
useEffect(() => {
function handleWindowResize() {
setWindowSize(getWindowSize());
}

window.addEventListener("resize", handleWindowResize);

return () => {
window.removeEventListener("resize", handleWindowResize);
};
}, []);
return (
<>
{windowSize.innerWidth > 1024 ? (
Copy link
Member

@rithviknishad rithviknishad Mar 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason to have this much complication. Wouldn't tailwind's modifiers be enough?

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 28, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

Hi, @gigincg, @nihal467, @khavinshankar, @mathew-alex, This pr has been automatically closed because it has not had any recent activity. Thank you for your contributions. Feel free to repopen the pr.

@github-actions github-actions bot closed this Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

View procedures in Patient Dashboard
2 participants