Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pagination is malfunctioning for the facility location management page #5051

Merged
merged 1 commit into from
Mar 7, 2023
Merged

fix: Pagination is malfunctioning for the facility location management page #5051

merged 1 commit into from
Mar 7, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Mar 7, 2023

Bug Fix

Proposed Changes

  • Fixed next button on the pagianation component

Associated Issue

Scrrenshot

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team March 7, 2023 04:33
@aeswibon aeswibon requested a review from a team as a code owner March 7, 2023 04:33
@aeswibon aeswibon added urgent needs testing P1 breaking issue or vital feature labels Mar 7, 2023
@vercel
Copy link

vercel bot commented Mar 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 7, 2023 at 4:36AM (UTC)

@netlify
Copy link

netlify bot commented Mar 7, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e87ca87
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6406be83a084b600073fb2f2
😎 Deploy Preview https://deploy-preview-5051--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Mar 7, 2023

LGTM

@khavinshankar khavinshankar merged commit dbb65f5 into ohcnetwork:develop Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pagination is malfunctioning for the facility location management page
3 participants
@aeswibon @nihal467 @khavinshankar