Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reorder and group the patient filters #5052

Merged
merged 5 commits into from
Apr 11, 2023
Merged

fix: reorder and group the patient filters #5052

merged 5 commits into from
Apr 11, 2023

Conversation

aeswibon
Copy link
Member

@aeswibon aeswibon commented Mar 7, 2023 •
edited
Loading

Bug Fix

Proposed Changes

  • Reordered and categorized the patient filters
  • Added header to each section

Associated Issue

Screenshot

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team March 7, 2023 05:03
@aeswibon aeswibon requested a review from a team as a code owner March 7, 2023 05:03
@aeswibon aeswibon requested a review from bodhish March 7, 2023 05:03
@vercel
Copy link

vercel bot commented Mar 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2023 9:59am

@netlify
Copy link

netlify bot commented Mar 7, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit ebc43c4
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64352f3e6365b30008ffbf40
😎 Deploy Preview https://deploy-preview-5052--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 7, 2023
@github-actions
Copy link

github-actions bot commented Mar 7, 2023

👋 Hi, @cp-Coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@nihal467
Copy link
Member

nihal467 commented Mar 7, 2023 •
edited by aeswibon
Loading

@cp-Coder
image

  • the UI doesn't look good in my view, so marking it for discussion in EOD
  • when a filter is applied, to see the applied filter in the advance filter, a user has to expand all the header, which seem be not good

@aeswibon
Copy link
Member Author

aeswibon commented Mar 7, 2023 •
edited
Loading

After discussing in the EOD:

  • Make all the sections expandable by default
  • Change the UI of the Accordion

@github-actions
Copy link

Hi, This pr has been automatically marked as stale because it has not had any recent activity. It will be automatically closed if no further activity occurs for 7 more days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Mar 16, 2023
@aeswibon aeswibon added needs testing and removed hold merge conflict pull requests with merge conflict stale labels Mar 24, 2023
@nihal467
Copy link
Member

nihal467 commented Mar 27, 2023 •
edited by aeswibon
Loading

@cp-Coder
image
image

  • the droplist is not visible in the advanced filters, it is happening with most of the fields

image

  • the sides of the droplist are getting cut out

note: Make sure you run a QA, before marking it for "Need testing"

@nihal467
Copy link
Member

nihal467 commented Apr 3, 2023 •
edited by aeswibon
Loading

@cp-Coder
image

  • when we minimize one header, the fields overlap the other header.
  • As mentioned in my previous comment, Add a QA video along with this PR, checking all the whole functions related to this PR.

@aeswibon
Copy link
Member Author

aeswibon commented Apr 3, 2023

@nihal467 the QA video:

2023-04-03.19-02-43.mp4

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

👋 Hi, @cp-Coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@aeswibon aeswibon added needs testing and removed test failed merge conflict pull requests with merge conflict labels Apr 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 11, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
67.3% 67.3% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit fe3dafc into ohcnetwork:develop Apr 11, 2023
rithviknishad added a commit that referenced this pull request Apr 12, 2023
@rithviknishad
Revert "fix: reorder and group the patient filters (#5052)"
b3e7e52 
This reverts commit fe3dafc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Advanced Filter: patient list- group and reorder
3 participants
@aeswibon @nihal467 @khavinshankar