Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced MUI components with custom components in ResetPassword.tsx #5063

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Replaced MUI components with custom components in ResetPassword.tsx #5063

merged 2 commits into from
Mar 21, 2023

Conversation

GokulramGHV
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Screenshot

image

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@GokulramGHV GokulramGHV requested a review from a team March 8, 2023 08:30
@GokulramGHV GokulramGHV requested a review from a team as a code owner March 8, 2023 08:30
@GokulramGHV GokulramGHV requested a review from bodhish March 8, 2023 08:30
@vercel
Copy link

vercel bot commented Mar 8, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 0:17AM (UTC)

@netlify
Copy link

netlify bot commented Mar 8, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 164dc39
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6410654cd9e19e0008abfbf5
😎 Deploy Preview https://deploy-preview-5063--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Pranshu1902
Copy link
Contributor

@GokulramGHV Maybe add a tick icon in the Reset button
image
@rithviknishad what do you think?

@rithviknishad
Copy link
Member

@Pranshu1902 I agree. @GokulramGHV make use of Submit button with label=Reset for consistency

@Pranshu1902 Pranshu1902 mentioned this pull request Mar 12, 2023
Closed
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 688a40c into coronasafe:develop Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@Pranshu1902 Pranshu1902 Pranshu1902 approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Auth/ResetPassword.tsx:
5 participants
@GokulramGHV @Pranshu1902 @rithviknishad @nihal467 @khavinshankar