Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added red border on select input fields and removed MUI #5089

Merged
merged 13 commits into from
Mar 14, 2023
Merged

Added red border on select input fields and removed MUI #5089

merged 13 commits into from
Mar 14, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Mar 10, 2023 •
edited
Loading

Fixes #5055
Added Red border for errors and removed MUI on forms

After:
image

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Pranshu1902 Pranshu1902 requested a review from a team March 10, 2023 16:22
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner March 10, 2023 16:22
@vercel
Copy link

vercel bot commented Mar 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 14, 2023 at 4:52AM (UTC)

@netlify
Copy link

netlify bot commented Mar 10, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 63bfe6e
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/640ffcd9da43d70008fc990b
😎 Deploy Preview https://deploy-preview-5089--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Pranshu1902
Copy link
Contributor Author

waiting for #5054

rithviknishad
rithviknishad reviewed Mar 10, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prefer using SelectFormField over SelectMenuV2

@netlify
Copy link

netlify bot commented Mar 10, 2023 •
edited
Loading

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 13dc899
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/640b5cf141b6f50008a4fa3b

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Mar 10, 2023
@Pranshu1902 Pranshu1902 removed the Deploy-Failed Deplyment is not showing preview label Mar 10, 2023
@rithviknishad
Copy link
Member

Why would you want to pass a requiredError separately when you can derive whether it's a required field and it has an error or not?

@Pranshu1902
Copy link
Contributor Author

Why would you want to pass a requiredError separately when you can derive whether it's a required field and it has an error or not?

@rithviknishad removed requiredError

@nihal467
Copy link
Member

nihal467 commented Mar 13, 2023 •
edited by Pranshu1902
Loading

@Pranshu1902 @rithviknishad
image

  • the ward is not a mandatory field
  • the date is currently shown in yyyy-mm-dd , and not in dd-mm-yyyy format which is mentioned in the error message

@Pranshu1902
Copy link
Contributor Author

@nihal467 Bug resolved
image

@nihal467
Copy link
Member

LGTM

khavinshankar
khavinshankar approved these changes Mar 14, 2023
View reviewed changes
src/Components/Users/UserAdd.tsx Outdated Show resolved Hide resolved
@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 14, 2023
@github-actions
Copy link

👋 Hi, @Pranshu1902,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Pranshu1902 Pranshu1902 removed the merge conflict pull requests with merge conflict label Mar 14, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.4% 0.4% Duplication

@khavinshankar khavinshankar merged commit 104bf37 into ohcnetwork:develop Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Red border color for all components on required error
4 participants
@Pranshu1902 @rithviknishad @nihal467 @khavinshankar