Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically center aligned State logo in Login page by modifying tailw… #5125

Merged

Conversation

rjhaveri1991
Copy link
Contributor

Proposed Changes

**Change 1**
- <div className="hidden md:flex gap-6 mb-4">
+ <div className="gap-6 mb-4 min-w-full max-w-lg">
**Change 2**
- <a href={coronasafe_url} className="inline-block" target="_blank" rel="noopener noreferrer">
+ <a href={coronasafe_url} className="flex flex-col items-center" target="_blank" rel="noopener noreferrer">
  • Issue Fix Screenshot
    Issue #5123 - Fix

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rjhaveri1991 rjhaveri1991 requested a review from a team March 17, 2023 21:43
@rjhaveri1991 rjhaveri1991 requested a review from a team as a code owner March 17, 2023 21:43
@vercel
Copy link

vercel bot commented Mar 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 18, 2023 at 7:00PM (UTC)

@netlify
Copy link

netlify bot commented Mar 17, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 5ee5a37
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/641609bf382051000875a28a
😎 Deploy Preview https://deploy-preview-5125--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rjhaveri1991 you've adjusted the horizontal center alignment.

image

Could you revert the changes and adjust the vertical alignment of the state logo instead and not the CARE logo?

To enable state_logo in preview, add the following to public/config.json file:

{
  "state_logo": "https://digitalpublicgoods.net/wp-content/themes/dpga/images/logo-w.svg",
}

once tested, we can remove it. the state_logo is an opt-in feature across deployments.

@rjhaveri1991
Copy link
Contributor Author

@rithviknishad - Got it, so state logo should be vertically center aligned in line with care logo right?

@rithviknishad
Copy link
Member

@rjhaveri1991 yes! affirmative.

@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rjhaveri1991
Copy link
Contributor Author

Proposed Changes

**Change**
- <div className="hidden md:flex gap-6 mb-4">
+ <div className="hidden md:flex items-center gap-6 mb-4">
  • Issue Fix Screenshot
    Issue #5123 - Fix

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Copy link
Member

@skks1212 skks1212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nihal467
Copy link
Member

LGTM @khavinshankar review it and merge it

@khavinshankar khavinshankar merged commit 6ea8c20 into coronasafe:develop Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vertically center align state logo in login page
5 participants