Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add bed occupancy to facility card #5131

Merged
merged 11 commits into from
May 25, 2023
Merged

Add bed occupancy to facility card #5131

merged 11 commits into from
May 25, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Mar 20, 2023 •
edited
Loading

Fixes #4885
Backend PR: coronasafe/care#1223

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team March 20, 2023 07:39
@Ashesh3 Ashesh3 requested a review from a team as a code owner March 20, 2023 07:39
@Ashesh3 Ashesh3 requested a review from gigincg March 20, 2023 07:39
@vercel
Copy link

vercel bot commented Mar 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 4:49pm

@netlify
Copy link

netlify bot commented Mar 20, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 15b6bdc
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/646e3fd359edbc0008f8a3d4
😎 Deploy Preview https://deploy-preview-5131--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@Ashesh3 Ashesh3 mentioned this pull request Mar 20, 2023
Merged
@github-actions
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Mar 21, 2023
@Ashesh3 Ashesh3 changed the title Ad bed occupancy to facility card Add bed occupancy to facility card Mar 21, 2023
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
2.0% 2.0% Duplication

@Ashesh3 Ashesh3 added work-in-progress and removed waiting for backend merge conflict pull requests with merge conflict labels May 1, 2023
@nihal467
Copy link
Member

nihal467 commented May 2, 2023 •
edited
Loading

LGTM, marking it as discussion for final UI approval

@nihal467
Copy link
Member

nihal467 commented May 3, 2023

@Ashesh3 work on the changes mentioned in the EOD

@Ashesh3
Copy link
Member Author

Ashesh3 commented May 3, 2023

Updated Design:
image
image
image

@nihal467
Copy link
Member

nihal467 commented May 3, 2023

@Ashesh3 marking it work in progress since the discussion is going on in slack

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label May 24, 2023
@github-actions
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@Ashesh3 Ashesh3 removed the merge conflict pull requests with merge conflict label May 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit b5f13ca into coronasafe:develop May 25, 2023
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Facility List: Adding bed occupancy
3 participants
@Ashesh3 @nihal467 @khavinshankar