Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added buttons for users card #5154

Merged
merged 8 commits into from
Apr 5, 2023

Conversation

Pranshu1902
Copy link
Contributor

Fixes #5132
Replaced text with buttons for linked facilities and skills
http://localhost:4000/users
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Pranshu1902 Pranshu1902 requested a review from a team March 23, 2023 08:21
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner March 23, 2023 08:21
@vercel
Copy link

vercel bot commented Mar 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 1, 2023 7:10am

@netlify
Copy link

netlify bot commented Mar 23, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3c15de9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6427d87d2600a40008114a0b
😎 Deploy Preview https://deploy-preview-5154--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

Marking it for final approval on UI

@nihal467
Copy link
Member

@Pranshu1902 add icons in the buttons

@Pranshu1902
Copy link
Contributor Author

Pranshu1902 commented Mar 29, 2023

@nihal467
Updated view:
image

@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Apr 3, 2023

LGTM

@nihal467 nihal467 added the tested label Apr 3, 2023
@khavinshankar khavinshankar merged commit 663358d into coronasafe:develop Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Revamp Show User linked skills button
3 participants