Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pain Scale data to be added in summary page #5163

Merged
merged 3 commits into from
Apr 5, 2023
Merged

fix: Pain Scale data to be added in summary page #5163

merged 3 commits into from
Apr 5, 2023

Conversation

aeswibon
Copy link
Member

Bug Fix

Proposed Changes

  • Adds Pain scale diagram in sunmmary tab of consultation page

Associated Issue

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team March 24, 2023 14:46
@aeswibon aeswibon requested a review from a team as a code owner March 24, 2023 14:46
@netlify
Copy link

netlify bot commented Mar 24, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 30b19c9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642a8cb9fab45700083edbdb
😎 Deploy Preview https://deploy-preview-5163--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@vercel
Copy link

vercel bot commented Mar 24, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 8:25am

@nihal467
Copy link
Member

nihal467 commented Mar 27, 2023 •
edited by aeswibon
Loading

@cp-Coder
image

https://deploy-preview-5163--care-net.netlify.app/facility/fc09dbc9-015a-4194-8dc8-14ccee34eee9/patient/61444d60-0aaf-4aa7-9463-b7a518969f9a/consultation/da16092c-972d-429f-a406-5958b6691110/summary

  • when we choose the previous date and time in the summary tab, the data is not getting changed
  • add a heading called pain scale on top.

note: Attach a video of the QA you are doing, to ensure that, all the bugs are covered along with this fix

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
7.0% 7.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Apr 3, 2023

LGTM

@khavinshankar khavinshankar merged commit 4ec5784 into coronasafe:develop Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
P2 tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Pain Scale data to be added in summary page
3 participants
@aeswibon @nihal467 @khavinshankar