Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: icon for respiratory support #5164

Merged
merged 6 commits into from
Apr 5, 2023

Conversation

aeswibon
Copy link
Member

Bug Fix

Proposed Changes

  • Added respiratory icon on patient list and consultation dashboard

Associated Issue

Screenshot

image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug/test a new feature.
  • Update product documentation
  • Ensure that UI text is kept in I18n files
  • Prep the screenshot or demo video for the changelog entry, and attach it to issue
  • Request for Peer Reviews
  • Completion of QA

@aeswibon aeswibon requested a review from a team March 24, 2023 15:23
@aeswibon aeswibon requested a review from a team as a code owner March 24, 2023 15:23
@aeswibon aeswibon requested a review from gigincg March 24, 2023 15:23
@vercel
Copy link

vercel bot commented Mar 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 4:18am

@netlify
Copy link

netlify bot commented Mar 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 096d739
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642cf645721b160008652484
😎 Deploy Preview https://deploy-preview-5164--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Mar 29, 2023

@cp-coder
image

  • the text is not properly centered inside the circle, it is a little bit upward

image

  • as per the issue, on the patient consultation page, the badges should be kept in the same row as the height, blood, etc... since you add the badge in entirely a new row, the whole UI feels stretched.

@nihal467
Copy link
Member

nihal467 commented Apr 3, 2023

LGTM

src/Components/Patient/PatientInfoCard.tsx Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

👋 Hi, @cp-coder,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.7% 0.7% Duplication

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Apr 5, 2023
@khavinshankar khavinshankar merged commit 9506e1a into ohcnetwork:develop Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icon for respiratory support- patient list and dashboard
3 participants