Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark all components from HelperInputFields as Deprecated #5173

Merged
merged 16 commits into from
Mar 27, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

  • Renames all components to Legacy<ComponentName> in HelperInputFields.tsx to explicitly prevent usage in favour of new components.
  • Removes unused legacy components.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team March 27, 2023 09:58
@rithviknishad rithviknishad requested a review from a team as a code owner March 27, 2023 09:58
@vercel
Copy link

vercel bot commented Mar 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Mar 27, 2023 at 9:58AM (UTC)

@netlify
Copy link

netlify bot commented Mar 27, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 301eaaa
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642168c702ce1b0008f9545a
😎 Deploy Preview https://deploy-preview-5173--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Mar 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.6% 0.6% Duplication

@khavinshankar khavinshankar merged commit 2c063da into develop Mar 27, 2023
@github-actions
Copy link

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Mar 27, 2023
@rithviknishad rithviknishad deleted the deprecate-helperinputfields branch July 26, 2023 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure needs review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants