-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Page redirection malfunction issue in the facility cns page #5200
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
LGTM |
@@ -95,7 +95,7 @@ export const FacilityCard = (props: { facility: any; userType: any }) => { | |||
{facility.name} | |||
</Link> | |||
<ButtonV2 | |||
href={`/facility/${facility.id}/cns`} | |||
href={`/facility/${facility.id}/cns?page=1`} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@patelaryan7751
instead of hardcoding the page, why not make the page = 1 when there is no query params passed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @khavinshankar i have removed all hardcoded links
👋 Hi, @patelaryan7751, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
Kudos, SonarCloud Quality Gate passed!
|
LGTM |
Proposed Changes
Fixed Page redirection malfunction issue in the facility cns page
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist