Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Page redirection malfunction issue in the facility cns page #5200

Merged
merged 7 commits into from
Apr 6, 2023
Merged

Fixed Page redirection malfunction issue in the facility cns page #5200

merged 7 commits into from
Apr 6, 2023

Conversation

patelaryan7751
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team March 29, 2023 17:31
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner March 29, 2023 17:31
@vercel
Copy link

vercel bot commented Mar 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 11:00am

@netlify
Copy link

netlify bot commented Mar 29, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 16ffe1d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642ea5e074152900082fffb4
😎 Deploy Preview https://deploy-preview-5200--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

nihal467 commented Apr 3, 2023

LGTM

khavinshankar
khavinshankar requested changes Apr 5, 2023
View reviewed changes
src/Components/Facility/FacilityCard.tsx Outdated
@@ -95,7 +95,7 @@ export const FacilityCard = (props: { facility: any; userType: any }) => {
{facility.name}
</Link>
<ButtonV2
href={`/facility/${facility.id}/cns`}
href={`/facility/${facility.id}/cns?page=1`}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@patelaryan7751
instead of hardcoding the page, why not make the page = 1 when there is no query params passed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @khavinshankar i have removed all hardcoded links

@github-actions github-actions bot added the merge conflict pull requests with merge conflict label Apr 5, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

👋 Hi, @patelaryan7751,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.

This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@sonarcloud
Copy link

sonarcloud bot commented Apr 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patelaryan7751 patelaryan7751 removed changes required merge conflict pull requests with merge conflict labels Apr 6, 2023
@nihal467
Copy link
Member

nihal467 commented Apr 6, 2023

LGTM

@khavinshankar khavinshankar merged commit 422c892 into ohcnetwork:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
P2 tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page redirection is malfunctioning in the facility cns page
3 participants
@patelaryan7751 @nihal467 @khavinshankar