Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added validation for 0 count in Add Bed Capacity #5202

Merged
merged 4 commits into from
Apr 6, 2023
Merged

Added validation for 0 count in Add Bed Capacity #5202

merged 4 commits into from
Apr 6, 2023

Conversation

Pranshu1902
Copy link
Contributor

Fixes #5201
Added validation for 0 count in Add Bed capacity
http://localhost:4000/facility/fc09dbc9-015a-4194-8dc8-14ccee34eee9
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Pranshu1902 Pranshu1902 requested a review from a team March 30, 2023 09:41
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner March 30, 2023 09:41
@vercel
Copy link

vercel bot commented Mar 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 3, 2023 8:43am

@netlify
Copy link

netlify bot commented Mar 30, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 53f765c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642a90fbef81f20008aa4f42
😎 Deploy Preview https://deploy-preview-5202--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rithviknishad
rithviknishad requested changes Mar 30, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranshu1902 can you also set the min prop of the field to 1 instead of 0?

@sonarcloud
Copy link

sonarcloud bot commented Apr 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

nihal467 commented Apr 3, 2023

LGTM

@khavinshankar
Copy link
Member

@rithviknishad can you rereview this pr

@khavinshankar khavinshankar merged commit f749d86 into coronasafe:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shouldn't be able to add Bed Capacity with count of 0
4 participants
@Pranshu1902 @nihal467 @khavinshankar @rithviknishad