Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replaced text with icons for Doctors List card #5231

Closed
wants to merge 8 commits into from
Closed

Replaced text with icons for Doctors List card #5231

wants to merge 8 commits into from

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented Apr 4, 2023 •
edited
Loading

Fixes #5230
Replaced text with icons for Edit and Delete buttons for Doctors List card
https://deploy-preview-5231--care-egov-staging.netlify.app/facility/56de8619-ac54-4517-b38b-93b4f83249c3
image
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@Pranshu1902 Pranshu1902 requested a review from a team April 4, 2023 09:18
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner April 4, 2023 09:18
@Pranshu1902 Pranshu1902 requested a review from gigincg April 4, 2023 09:18
@vercel
Copy link

vercel bot commented Apr 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 4:31pm

@netlify
Copy link

netlify bot commented Apr 4, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit e6813f9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6436dca3c42d790008fe4837
😎 Deploy Preview https://deploy-preview-5231--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Apr 5, 2023

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 6b396d6
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/642d4a9cb151ad00086b93ae

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 5, 2023
@nihal467 nihal467 removed the Deploy-Failed Deplyment is not showing preview label Apr 5, 2023
@nihal467
Copy link
Member

@Pranshu1902
image

changing into icons doesn't look good, my suggestion would be

  • get rid of the grey area in the card and keep the icons in a plain area, as we did for the bed capacity
  • or think about it from a better design perspective, and push a new idea you feel would be good

@Pranshu1902
Copy link
Contributor Author

@nihal467
Updated view:
image

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

@Pranshu1902 I am holding this PR, as doesn't feel relevant to make the change now.

@nihal467 nihal467 closed this Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
hold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Buttons for Doctors List card
2 participants
@Pranshu1902 @nihal467