Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor 'Description Advice' in ConsultationDetails component #5233

Merged
merged 6 commits into from
Apr 6, 2023
Merged

Refactor 'Description Advice' in ConsultationDetails component #5233

merged 6 commits into from
Apr 6, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Apr 4, 2023

Fixes #5196

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@Ashesh3 Ashesh3 requested a review from a team April 4, 2023 13:12
@Ashesh3 Ashesh3 requested a review from a team as a code owner April 4, 2023 13:12
@Ashesh3 Ashesh3 requested a review from vigneshhari April 4, 2023 13:12
@vercel
Copy link

vercel bot commented Apr 4, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 0:02am

@netlify
Copy link

netlify bot commented Apr 4, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9ccbcf1
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/642d62e2f65e430008bb91df
😎 Deploy Preview https://deploy-preview-5233--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467 nihal467 added the P2 label Apr 5, 2023
@nihal467 nihal467 added P1 breaking issue or vital feature urgent work-in-progress and removed P2 needs testing labels Apr 5, 2023
@nihal467
Copy link
Member

nihal467 commented Apr 5, 2023

@Ashesh3 change "Discharge SOS Prescription" to "Discharge PRN Prescription"

@netlify
Copy link

netlify bot commented Apr 5, 2023 •
edited
Loading

❌ Deploy Preview for care-net failed.

Name Link
🔨 Latest commit 3dcef6d
🔍 Latest deploy log https://app.netlify.com/sites/care-net/deploys/642d46b5051df90008fdea7a

@github-actions github-actions bot added the Deploy-Failed Deplyment is not showing preview label Apr 5, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.4% 1.4% Duplication

@nihal467 nihal467 removed the Deploy-Failed Deplyment is not showing preview label Apr 5, 2023
@nihal467
Copy link
Member

nihal467 commented Apr 5, 2023

LGTM

@khavinshankar khavinshankar merged commit 0bea535 into coronasafe:develop Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nihal467 nihal467 nihal467 left review comments

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Discharge: recovered- rename field
3 participants
@Ashesh3 @nihal467 @khavinshankar