Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Malfunctioning of Patient category advance filter in patient tab #5274

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Fixed Malfunctioning of Patient category advance filter in patient tab #5274

merged 5 commits into from
Apr 12, 2023

Conversation

patelaryan7751
Copy link
Contributor

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@patelaryan7751 patelaryan7751 requested a review from a team April 7, 2023 15:01
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner April 7, 2023 15:01
@vercel
Copy link

vercel bot commented Apr 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 11:16am

@netlify
Copy link

netlify bot commented Apr 7, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 485906c
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64369292d1cdcd0008d6d341
😎 Deploy Preview https://deploy-preview-5274--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@patelaryan7751
image

there is a undefined badge is by default showing in patient tab

@nihal467 nihal467 added urgent P1 breaking issue or vital feature and removed P2 labels Apr 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patelaryan7751
Copy link
Contributor Author

Hey @nihal467 the bug is fixed.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 0d6296c into coronasafe:develop Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
P1 breaking issue or vital feature tested urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Patient category advance filter in patient tab is malfunctioning
4 participants
@patelaryan7751 @nihal467 @rithviknishad @khavinshankar