Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consultation Form: Navigate to Create Shift on submit if "Decision after consultation" is "Refer to another Hospital" #5298

Merged
merged 4 commits into from
May 2, 2023

Conversation

rithviknishad
Copy link
Member

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

@rithviknishad rithviknishad requested a review from a team April 10, 2023 13:14
@rithviknishad rithviknishad requested a review from a team as a code owner April 10, 2023 13:14
@vercel
Copy link

vercel bot commented Apr 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 2, 2023 9:24am

@netlify
Copy link

netlify bot commented Apr 10, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 335c136
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6450d6a8027b650008120c68
😎 Deploy Preview https://deploy-preview-5298--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@rithviknishad rithviknishad added needs testing P1 breaking issue or vital feature shifting and removed shifting labels Apr 10, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 10, 2023
@nihal467
Copy link
Member

nihal467 commented Apr 11, 2023

@aparnacoronasafe @rithviknishad

image

  • when we are redirected to the new shifting request page automatically, and the user click cancel button in the shifting form, the user is redirected to the consultation form , rather than the patient consultation page. Is it intentional ?
  • the patient shift function works only within facilities of care, if they are been referred to hospital outside care, and they are forced to fill the shifting request form right ?

@aparnacoronasafe
Copy link
Member

  1. when user clicks on cancel in shifting form, the user must be taken to the patient dashboard.
  2. we are already making changes to the shifting form to note whenever a patient is shifted to a hospital outside care. The issues are marked with a label "shifting".

@rithviknishad rithviknishad added changes required and removed needs testing cypress failed pull request with cypress test failure labels Apr 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions github-actions bot added the cypress failed pull request with cypress test failure label May 2, 2023
@nihal467
Copy link
Member

nihal467 commented May 2, 2023

LGTM

@khavinshankar khavinshankar merged commit a9ed374 into develop May 2, 2023
25 of 26 checks passed
@khavinshankar khavinshankar deleted the issues/5296 branch May 2, 2023 09:34
@github-actions
Copy link

github-actions bot commented May 2, 2023

@rithviknishad We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature shifting tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consultation- referral- shifting request
4 participants