Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "fix: reorder and group the patient filters (#5052)" #5326

Closed
wants to merge 1 commit into from
Closed

Revert "fix: reorder and group the patient filters (#5052)" #5326

wants to merge 1 commit into from

Conversation

rithviknishad
Copy link
Member

@rithviknishad rithviknishad commented Apr 12, 2023 •
edited by ghost
Loading

This reverts commit fe3dafc.

WHAT

🤖 Generated by Copilot at b3e7e52

Refactored and enhanced the AccordionV2 component for better UI and UX.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at b3e7e52

  • Prevent content overflow in accordion component (link, link)
  • Add overflow-hidden class to content wrapper div (link)
  • Adjust maxHeight style to use scrollHeight of content element (link)
  • Remove redundant overflow style from collapsed state (link)
  • Remove unused import of classNames from AccordionV2.tsx (link)

@rithviknishad rithviknishad requested a review from a team April 12, 2023 11:42
@rithviknishad rithviknishad requested a review from a team as a code owner April 12, 2023 11:42
@vercel
Copy link

vercel bot commented Apr 12, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 12, 2023 11:43am

@netlify
Copy link

netlify bot commented Apr 12, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit b3e7e52
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/643699196fb171000887a482
😎 Deploy Preview https://deploy-preview-5326--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@rithviknishad rithviknishad added urgent P1 breaking issue or vital feature labels Apr 12, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label Apr 12, 2023
@rithviknishad rithviknishad deleted the revert-5052 branch July 26, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
cypress failed pull request with cypress test failure needs testing P1 breaking issue or vital feature urgent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rithviknishad