Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix facility filter in asset page #5341

Merged
merged 1 commit into from
Apr 14, 2023
Merged

Fix facility filter in asset page #5341

merged 1 commit into from
Apr 14, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Apr 14, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 68454b8

Refactored and optimized the AssetFilter component to make it more efficient and clear.

Proposed Changes

image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

🤖 Generated by Copilot at 68454b8

There once was a file called AssetFilter
That had some redundant code in it
The logic was simplified
The facility state clarified
And now the component is much fitter

HOW

🤖 Generated by Copilot at 68454b8

  • Removed unnecessary console.log statement (link)
  • Simplified async call to dispatch and error handling logic (link)
  • Used optional chaining to access facility data (link)

@Ashesh3 Ashesh3 requested a review from a team April 14, 2023 13:29
@Ashesh3 Ashesh3 requested a review from a team as a code owner April 14, 2023 13:29
@Ashesh3 Ashesh3 requested a review from bodhish April 14, 2023 13:29
@vercel
Copy link

vercel bot commented Apr 14, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 1:30pm

@netlify
Copy link

netlify bot commented Apr 14, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 68454b8
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6439552e4e9c8c0008579f3a
😎 Deploy Preview https://deploy-preview-5341--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.3% 1.3% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit aa2d61b into coronasafe:develop Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@bodhish bodhish Awaiting requested review from bodhish

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Something went wrong error in asset page
3 participants
@Ashesh3 @nihal467 @khavinshankar