Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made UI Responsive for Issue #5331 #5344

Merged
merged 4 commits into from
Apr 19, 2023
Merged

Made UI Responsive for Issue #5331 #5344

merged 4 commits into from
Apr 19, 2023

Conversation

AbhishekPSingh07
Copy link
Contributor

@AbhishekPSingh07 AbhishekPSingh07 commented Apr 15, 2023 •
edited by Pranshu1902
Loading

Fixes #5331

WHAT

To make the page responsive

The Linked Facilities is now same as the Linked Skills after adding padding.
Screenshot 2023-04-16 at 4 05 19 AM
Screenshot 2023-04-16 at 4 05 27 AM

@AbhishekPSingh07 AbhishekPSingh07 requested a review from a team April 15, 2023 22:43
@AbhishekPSingh07 AbhishekPSingh07 requested a review from a team as a code owner April 15, 2023 22:43
@vercel
Copy link

vercel bot commented Apr 15, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2023 6:52am

@netlify
Copy link

netlify bot commented Apr 15, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit fb0107b
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/643f8f6438ba2700089bcaa9
😎 Deploy Preview https://deploy-preview-5344--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@AbhishekPSingh07 AbhishekPSingh07 mentioned this pull request Apr 15, 2023
Closed
rithviknishad
rithviknishad requested changes Apr 16, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pass 'p-6' in the dialogClass at the usage instead of of modifying the generic slideover component. Applying here will affect all usages across the platform and is undesired.

rithviknishad
rithviknishad approved these changes Apr 18, 2023
View reviewed changes
src/Components/Users/ManageUsers.tsx Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Apr 19, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit db7b9b2 into coronasafe:develop Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Page not responsive
4 participants
@AbhishekPSingh07 @nihal467 @rithviknishad @khavinshankar