Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Issue 5350 #5352

Merged
merged 7 commits into from
Apr 19, 2023
Merged

Fixed Issue 5350 #5352

merged 7 commits into from
Apr 19, 2023

Conversation

suprabathk
Copy link
Contributor

@suprabathk suprabathk commented Apr 18, 2023 •
edited by ghost
Loading

WHAT

ButtonV2 has whitespace-pre class, so this prevents the button from breaking to multiple lines.

🤖 Generated by Copilot at 3387a6d

Fixed a UI bug in the ShiftCard component that caused text overflow or wrapping in small screens. Modified the Button element in src/Components/Shifting/ShiftingBoard.tsx to use the sm:whitespace-normal class.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 3387a6d

  • Fix UI bug in shifting board component by adding sm:whitespace-normal class to Button element in ShiftCard component (link)

@suprabathk suprabathk requested a review from a team April 18, 2023 13:42
@suprabathk suprabathk requested a review from a team as a code owner April 18, 2023 13:42
@suprabathk suprabathk requested a review from gigincg April 18, 2023 13:42
@vercel
Copy link

vercel bot commented Apr 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 18, 2023 1:44pm

@netlify
Copy link

netlify bot commented Apr 18, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 3387a6d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/643e9e4ae5b8ff0008f3e9f9
😎 Deploy Preview https://deploy-preview-5352--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 71c9ee7 into coronasafe:develop Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Transfer button text is overflowing out of the button in scaled displays
4 participants
@suprabathk @nihal467 @rithviknishad @khavinshankar