Fixed malfunction of filters #5362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
SonarCloud Quality Gate failed.
|
6 tasks
|
LGTM |
khavinshankar
approved these changes
Apr 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
🤖 Generated by Copilot at 58bab83
This pull request adds or improves filtering and ordering features for various data types, such as assets, shifting, resources, samples, patients, and users. It also fixes a bug where the filter values were not reset when the query parameters changed. It does so by adding a
keyprop to the filter components, which is set to the current window location search string, and by using constants and functions to map the query values to more descriptive texts. The changes affect several files, such asAssetsList.tsx,BadgesList.tsx,FacilityFilter.tsx,ListFilter.tsx, andUserFilter.tsx.Proposed Changes
Fixed malfunction of filters
@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 58bab83
keyprop to various filter components to ensure they are re-rendered when the query parameters change and the filter values are reset accordingly (link, link, link, link, link, link, link, link, link, link)facilityNameto store the fetched name of the selected facility in theAssetsListcomponent and use it to display the facility name badge (link, link, link)getDescShiftingFilterOrderto display the ordering filter badge for shifting data with a more descriptive text instead of the query parameter value, using theSHIFTING_FILTER_ORDERconstant (link, link, link, link, link)BadgesListcomponent (link)