Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Bed capacity malfunctioning in the facility create page #5377

Merged
merged 1 commit into from
Apr 26, 2023
Merged

Fixed Bed capacity malfunctioning in the facility create page #5377

merged 1 commit into from
Apr 26, 2023

Conversation

patelaryan7751
Copy link
Contributor

@patelaryan7751 patelaryan7751 commented Apr 23, 2023 •
edited by ghost
Loading

WHAT

🤖 Generated by Copilot at 4985394

This pull request enhances the facility creation form by fixing a bug and improving the UI for bed types and capacities. It simplifies the logic in FacilityCreate.tsx and handles missing data better.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 4985394

  • Remove unnecessary capacity check for new bed types (link)
  • Add fallback value of 0 for missing capacity data in BedTypeCard component (link)

@patelaryan7751 patelaryan7751 requested a review from a team April 23, 2023 21:37
@patelaryan7751 patelaryan7751 requested a review from a team as a code owner April 23, 2023 21:37
@vercel
Copy link

vercel bot commented Apr 23, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 23, 2023 9:39pm

@netlify
Copy link

netlify bot commented Apr 23, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4985394
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6445a53233cdee0008cb3b1b
😎 Deploy Preview https://deploy-preview-5377--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented Apr 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 210dd93 into coronasafe:develop Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khavinshankar khavinshankar khavinshankar approved these changes

@mathew-alex mathew-alex Awaiting requested review from mathew-alex

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bed capacity is malfunctioning in the facility create page
3 participants
@patelaryan7751 @nihal467 @khavinshankar