Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add service request history to asset #5417

Merged
merged 7 commits into from
Aug 25, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented Apr 27, 2023

WHAT

🤖 Generated by Copilot at b4eb554

Added functionality to view and manage asset service logs in the frontend. Updated the asset data type to include the last service log as a nested object. Added new actions and routes to handle the asset service API requests. Modified the AssetManage, AssetCreate, and AssetTypes components to reflect the changes.

Fixes #5363
Backend PR: ohcnetwork/care#1277

image
image
image
image

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at b4eb554

  • Add AssetService type to ./AssetTypes to represent service log data (link, link)
  • Remove last_serviced_on and notes from AssetData type and replace with last_service of type AssetService to include last service log as a nested object (link)
  • Update AssetManage component to fetch and display service logs for an asset using listAssetService action (link, link, link, link, link, link, link)
  • Update AssetManage and AssetCreate components to use last_service.serviced_on and last_service.note instead of last_serviced_on and notes to access last service log data (link, link, link)
  • Add listAssetService and getAssetService actions to ../../Redux/actions to make API requests to asset service endpoints (link)
  • Add listAssetService and getAssetService routes to ../../Redux/api to define path and method for asset service endpoints (link)

@Ashesh3 Ashesh3 requested a review from a team April 27, 2023 16:17
@Ashesh3 Ashesh3 requested a review from a team as a code owner April 27, 2023 16:17
@Ashesh3 Ashesh3 requested a review from gigincg April 27, 2023 16:17
@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 25, 2023 10:25am

@netlify
Copy link

netlify bot commented Apr 27, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 98398e9
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64e88173751824000843c881
😎 Deploy Preview https://deploy-preview-5417--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sonarcloud
Copy link

sonarcloud bot commented Apr 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
1.6% 1.6% Duplication

@github-actions
Copy link

👋 Hi, @Ashesh3,
Conflicts have been detected against the base branch. Please rebase your branch against the base branch.


This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there.

@github-actions github-actions bot removed the merge conflict pull requests with merge conflict label Aug 22, 2023
@Ashesh3
Copy link
Member Author

Ashesh3 commented Aug 23, 2023

Added edit history as per discussion. Updated Screenshots in PR description.

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit 8277753 into ohcnetwork:develop Aug 25, 2023
25 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Service Request: Assets
3 participants