Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update package.json to fix care_fe local #5455

Merged
merged 1 commit into from
May 9, 2023
Merged

Conversation

nihal467
Copy link
Member

@nihal467 nihal467 commented May 8, 2023

WHAT

🤖 Generated by Copilot at 770e82d

Fixed CSV export bug and improved code formatting. Updated react-csv dependency in package.json and added newline at the end of the file.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 770e82d

  • Updated the react-csv dependency to fix a CSV export bug (link)
  • Added a newline character at the end of package.json for JSON formatting (link)

@nihal467 nihal467 requested a review from a team May 8, 2023 19:36
@nihal467 nihal467 requested a review from a team as a code owner May 8, 2023 19:36
@nihal467 nihal467 requested a review from mathew-alex May 8, 2023 19:36
@vercel
Copy link

vercel bot commented May 8, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview May 8, 2023 7:36pm

@netlify
Copy link

netlify bot commented May 8, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 770e82d
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64594f38cb7181000817dfc5
😎 Deploy Preview https://deploy-preview-5455--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467 nihal467 added urgent P1 breaking issue or vital feature labels May 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member Author

nihal467 commented May 8, 2023

@khavinshankar it works well now in windows now, can you check with linux before merging it

@nihal467 nihal467 added the tested label May 8, 2023
@github-actions github-actions bot added the cypress failed pull request with cypress test failure label May 8, 2023
@khavinshankar khavinshankar merged commit 4c1af9b into develop May 9, 2023
@khavinshankar khavinshankar deleted the nihal467-patch-1 branch May 9, 2023 07:46
@github-actions
Copy link

github-actions bot commented May 9, 2023

@nihal467 We truly appreciate your efforts. Thank you for taking the time to contribute; this is a very valuable contribution to us 🥇. We always welcome your contribution 🙂, so feel free to contribute to anything anytime, and never lose that spirit of innovation 🙌.

rithviknishad added a commit that referenced this pull request May 18, 2023
khavinshankar pushed a commit that referenced this pull request May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cypress failed pull request with cypress test failure P1 breaking issue or vital feature tested urgent
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Care_fe is crashing when we are running locally
2 participants