Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error messages for doctor capacity form #5461

Merged
merged 2 commits into from
May 16, 2023

Conversation

Ashesh3
Copy link
Member

@Ashesh3 Ashesh3 commented May 11, 2023

Fixes #5432

WHAT

🤖 Generated by Copilot at df9ea91

This change updates the UI of the facility modal to use a common button component and a simpler form structure. This enhances the user experience and the code readability of the DoctorCapacity component in src/Components/Facility/DoctorCapacity.tsx.

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

HOW

🤖 Generated by Copilot at df9ea91

  • Replace the Submit component with the ButtonV2 component for consistency and reusability (link)
  • Remove the form element and the onSubmit prop from the DoctorCapacity component and use the onClick prop of the ButtonV2 components to handle the form submission (link)

@Ashesh3 Ashesh3 requested a review from a team May 11, 2023 20:01
@Ashesh3 Ashesh3 requested a review from a team as a code owner May 11, 2023 20:01
@Ashesh3 Ashesh3 requested a review from bodhish May 11, 2023 20:01
@vercel
Copy link

vercel bot commented May 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 15, 2023 0:55am

@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 531dca3
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/64622b68ce3d03000865756d
😎 Deploy Preview https://deploy-preview-5461--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nihal467
Copy link
Member

@Ashesh3
image

when you click the "Save Doctor Capacity" button, the user is staying on the page, but it should redirect the person to the facility detail page.

@Ashesh3
Copy link
Member Author

Ashesh3 commented May 15, 2023

@Ashesh3 image

when you click the "Save Doctor Capacity" button, the user is staying on the page, but it should redirect the person to the facility detail page.

Fixed

@sonarcloud
Copy link

sonarcloud bot commented May 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
1.7% 1.7% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit ae77ab9 into coronasafe:develop May 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add proper validation in Doctor Capacity Page
3 participants