Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added response view to Update log #5497

Merged
merged 4 commits into from
May 25, 2023
Merged

Added response view to Update log #5497

merged 4 commits into from
May 25, 2023

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented May 20, 2023 •
edited
Loading

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 351c111

  • Adjust the layout of the consultation details page to use different flex directions for different screen sizes (link)

@Pranshu1902 Pranshu1902 requested a review from a team May 20, 2023 21:07
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner May 20, 2023 21:07
@vercel
Copy link

vercel bot commented May 20, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook 🔄 Building (Inspect) Visit Preview Aug 31, 2024 4:51pm
care-storybook-1725120970416-WfiY 🛑 Canceled (Inspect) Aug 31, 2024 4:51pm

@netlify
Copy link

netlify bot commented May 20, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 79443a7
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/646e6712c2efa60008f469e0
😎 Deploy Preview https://deploy-preview-5497--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rithviknishad
rithviknishad requested changes May 21, 2023
View reviewed changes
Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Pranshu1902 can you reduce the vertical spacing and between the title and the checkbox and increase between the checkbox and the log update tiles for the mobile view?

@Pranshu1902
Copy link
Contributor Author

@rithviknishad Updated view:
image

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nihal467
Copy link
Member

LGTM

@khavinshankar khavinshankar merged commit d836b03 into ohcnetwork:develop May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Minor Resposive view issue
4 participants
@Pranshu1902 @nihal467 @rithviknishad @khavinshankar