Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unblocked input field from browser autofill #5509

Conversation

Deepanshu039
Copy link

@Deepanshu039 Deepanshu039 commented May 24, 2023

WHAT

input fields were getting blocked by browser autofill.

Proposed Changes

##Before
image

##After
image

@Deepanshu039 Deepanshu039 requested a review from a team May 24, 2023 10:08
@Deepanshu039 Deepanshu039 requested a review from a team as a code owner May 24, 2023 10:08
@Deepanshu039 Deepanshu039 requested a review from bodhish May 24, 2023 10:08
@vercel
Copy link

vercel bot commented May 24, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 24, 2023 10:09am

@netlify
Copy link

netlify bot commented May 24, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 4b79c96
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/646de22c5d77c60008ae08ae
😎 Deploy Preview https://deploy-preview-5509--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, @Deepanshu039 could you set this as the default for all AutocompleteFormFields?

@Deepanshu039
Copy link
Author

You are saying that I disable autocomplete attribute to all the forms, or you are suggesting any global way to achieve the same? Please help me with that.

@rithviknishad
Copy link
Member

Not all forms, only for AutocompleteFormField and it's multi select equivalent. Have a look at FormField components.

@Deepanshu039
Copy link
Author

okay got it.

@rithviknishad
Copy link
Member

@Deepanshu039 any updates on this?

@rithviknishad
Copy link
Member

fixed properly in #5541

@Deepanshu039
Copy link
Author

sorry @rithviknishad for not replying actually I was caught up in stuff but I was looking at the code to fix this issue.

@nihal467
Copy link
Member

@Deepanshu039 It would be great if, next time, you could respond with a "thumbs up" reaction or an acknowledged kind of general reply. This way, we would know that you have seen the message and are currently working on it. You are welcome to take on all other good first issues.

@Deepanshu039
Copy link
Author

I'll remember this definitely. Again sorry for not being prompt this time.

@rithviknishad
Copy link
Member

No worries @Deepanshu039 😄
Had to push this out since today is production release day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser autocomplete is blocking the view of AutocompleteFormField's dropdown.
3 participants