-
Notifications
You must be signed in to change notification settings - Fork 347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unblocked input field from browser autofill #5509
Unblocked input field from browser autofill #5509
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, @Deepanshu039 could you set this as the default for all AutocompleteFormFields
?
You are saying that I disable autocomplete attribute to all the forms, or you are suggesting any global way to achieve the same? Please help me with that. |
Not all forms, only for |
okay got it. |
@Deepanshu039 any updates on this? |
fixed properly in #5541 |
sorry @rithviknishad for not replying actually I was caught up in stuff but I was looking at the code to fix this issue. |
@Deepanshu039 It would be great if, next time, you could respond with a "thumbs up" reaction or an acknowledged kind of general reply. This way, we would know that you have seen the message and are currently working on it. You are welcome to take on all other good first issues. |
I'll remember this definitely. Again sorry for not being prompt this time. |
No worries @Deepanshu039 😄 |
WHAT
input fields were getting blocked by browser autofill.
Proposed Changes
##Before
![image](https://private-user-images.githubusercontent.com/92849065/240568009-621c6237-041d-4907-b9b2-8355faa5ba62.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3MTAxNzUsIm5iZiI6MTcyMDcwOTg3NSwicGF0aCI6Ii85Mjg0OTA2NS8yNDA1NjgwMDktNjIxYzYyMzctMDQxZC00OTA3LWI5YjItODM1NWZhYTViYTYyLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzExVDE0NTc1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWI5YjZiYzk4ZTY5ZDRjN2RhZTA4M2I4MzJjNmEwMTg1M2M3NmJiN2RhODA2NDZhZmY5Yzk2ZDYxMTg5NjUyOTgmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.ALHonL-yHJscOs3pEXWRzf7Ifrogvhk7IZpvegpIwfI)
##After
![image](https://private-user-images.githubusercontent.com/92849065/240568163-6a979c8b-ffed-49db-984f-5631803ecf93.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjA3MTAxNzUsIm5iZiI6MTcyMDcwOTg3NSwicGF0aCI6Ii85Mjg0OTA2NS8yNDA1NjgxNjMtNmE5NzljOGItZmZlZC00OWRiLTk4NGYtNTYzMTgwM2VjZjkzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MTElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzExVDE0NTc1NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTc4NzQwYjMwMDYyYjdkMTc2N2U0N2MxZDJhYTQ1M2Y0MGRlZmY2ZWE1ZWQ2M2JkODIyYWMwM2JhMDdlYzFjMGQmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.zHH_w-IHptpcuYaLYJ0PX-pPOitU-bSgfBIHfrEYCzQ)