Replaced MaterialUI in DeathReport and used Form Component Fixes #4939 #5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
rithviknishad
requested changes
May 25, 2023
There was a problem hiding this comment.
- Avoid keeping 3 fields per row, it looks congested.
- In mobile view you may keep 1 field per row.
Consider keeping the grid grid-cols-1 md:grid-cols-2 in the parent instead of each row.
@nihal467 to share screenshots
- Increase the width of the form in normal view, to avoid the field name going to the second row
- in the responsive view, most of the fields are not properly viewed to entered data, suggestions, make each field per row in mobile view and don't change in normal view
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHAT
Replaced MaterialUI components and legacy form fields with new form fields. Wrapped all fields inside Form component
Proposed Changes
src/Components/DeathReport/DeathReport.tsx: #4939@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
HOW
🤖 Generated by Copilot at f4ba972
max-w-3xlclass fromFormcomponent to make it more responsive (link)max-w-3xlclass toCreatePrescriptionFormcomponent to limit its width (link)