Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep search text #5528

Merged
merged 9 commits into from
May 30, 2023
Merged

Conversation

MayaSatishRao
Copy link
Contributor

@MayaSatishRao MayaSatishRao commented May 25, 2023

WHAT

🤖 Generated by Copilot at 0b82667

This pull request improves the user interface and functionality of the CSV export feature and the AutoCompleteAsync component. It changes the format of the export filenames to include the date and time, and it fixes a bug where the input field would not display the typed query.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

@MayaSatishRao MayaSatishRao requested a review from a team May 25, 2023 19:21
@MayaSatishRao MayaSatishRao requested a review from a team as a code owner May 25, 2023 19:21
@vercel
Copy link

vercel bot commented May 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 30, 2023 9:24am

@netlify
Copy link

netlify bot commented May 25, 2023

Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 9003977
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6475c09a71d9ac00095e4d34
😎 Deploy Preview https://deploy-preview-5528--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

src/Common/hooks/useExport.tsx Outdated Show resolved Hide resolved
@rithviknishad
Copy link
Member

@MayaSatishRao your solution still doesn't solve the problem

@MayaSatishRao
Copy link
Contributor Author

@rithviknishad I have removed the changes from old branch and made new changes. Hope this solves the problem

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue is still present. Are you not testing it yourself? Kindly test from your local before requesting a review.

image

@MayaSatishRao
Copy link
Contributor Author

In the expected behavior of the issue, only 1 thing was mentioned: the search text in the input box must not be cleared. According to your last comment, I understood that the problem is all facilities are not listed even the search text is empty. Am I right?
Since I do not have the backend setup, I cannot test it on my machine. Should I set the backend as well?

@MayaSatishRao
Copy link
Contributor Author

@rithviknishad ⬆️

@rithviknishad
Copy link
Member

@MayaSatishRao but even the expected behaviour is not working. Either one should work.

Also, you don't need to setup the backend to run the front-end. By default, it'll use the staging backend.

@MayaSatishRao
Copy link
Contributor Author

ok i will look into it

@MayaSatishRao
Copy link
Contributor Author

@rithviknishad, now I have made changes such that all options are displayed instead of making the previous query displayed in the text input. Is that fine?
when searched for "ba":
infocus
when out of focus and then again search with empty query:
outfocus

@rithviknishad
Copy link
Member

rithviknishad commented May 26, 2023

Nice! This should be fine

@MayaSatishRao
Copy link
Contributor Author

ok, I will make the changes!!

@MayaSatishRao
Copy link
Contributor Author

@rithviknishad I have made the changes! I have tested it as well.

@MayaSatishRao
Copy link
Contributor Author

are the changes working? @rithviknishad

Copy link
Member

@rithviknishad rithviknishad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @MayaSatishRao

@nihal467
Copy link
Member

LGTM

@sonarcloud
Copy link

sonarcloud bot commented May 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 01354f4 into coronasafe:develop May 30, 2023
29 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not able to view all facilities on users page
4 participants