-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changed UI for Live/Discharged Tabs in Patients Page #5543
Changed UI for Live/Discharged Tabs in Patients Page #5543
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for care-egov-staging ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
@nihal467 I've made the requested changes |
LGTM |
👋 Hi, @GokulramGHV, This message is automatically generated by prince-chrismc/label-merge-conflicts-action so don't hesitate to report issues/improvements there. |
<i className="fa fa-filter" aria-hidden="true"></i> | ||
<span className="py-0.5">{t("advanced_filters")}</span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@GokulramGHV can you use care icon instead of font-awesome
src/Components/Shifting/ListView.tsx
Outdated
<i | ||
className="fa fa-list mr-1 transform rotate-90" | ||
aria-hidden="true" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too, use care icon
@GokulramGHV clear the merge conflict |
@GokulramGHV check the failed cypress |
Kudos, SonarCloud Quality Gate passed!
|
@GokulramGHV fix the cypress, the test is failing since you change the button |
@nihal467 is attempting to deploy a commit to the Coronasafe Team on Vercel. A member of the Team first needs to authorize it. |
LGTM |
WHAT
🤖 Generated by Copilot at 5f17ac0
This pull request updates several components in the
coronasafe/care_fe
repository to improve the UI, UX, and localization of different views. It introduces a new component calledSwitchTabs
that can be used to switch between tabs, and replaces theNavTabs
component with it. It also replaces thebutton
elements with theButtonV2
components, which provide a consistent and customizable UI for buttons. It also uses theuseTranslation
hook and thet
function to translate the text based on the current language. It also modifies the layout and alignment of the header sections of different views to make them more consistent and responsive.Proposed Changes
SwitchTabs
SwitchTabs
components for (Active/Completed) in Resource and Shifting pages.@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers
Merge Checklist
HOW
🤖 Generated by Copilot at 5f17ac0
SwitchTabs
component that renders two buttons for tab switching (link)NavTabs
component with theSwitchTabs
component in thePatientManager
component, and comment out the unused code (link, link, link, link)SwitchTabs
component in theResourceBoardView
andBoardView
components, and adjust the layout and spacing of the header elements (link, link, link, link, link)ButtonV2
component that provides a consistent and customizable UI for buttons, and use it in theAssetsList
,ListView
,ResourceBoardView
, andBoardView
components, replacing thebutton
elements (link, link, link, link, link, link, link, link, link)useTranslation
hook that enables localization of the UI text, and use it in theListView
andResourceBoardView
components, adding thet
function to the button text (link, link, link, link)PageTitle
and theAdd Patient Details
button in thePatientManager
component, and move them to the left side of the header (link, link)Loading
component in thePatientManager
component to match the new layout of the header (link)className
attribute to thespan
element in theAdvancedFilterButton
component, which sets the vertical padding to 0.5 units (link)NavTabs
component from theManagePatients
component (link)BoardView
component to avoid overflow (link)