Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replaced MUI dialog and related components with DialogModal #5570

Merged
merged 6 commits into from
Jun 7, 2023
Merged

replaced MUI dialog and related components with DialogModal #5570

merged 6 commits into from
Jun 7, 2023

Conversation

sachdevavaibhav
Copy link
Contributor

@sachdevavaibhav sachdevavaibhav commented May 30, 2023 •
edited
Loading

WHAT

Replaced MUI Dialog and related components with DialogModal component.

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers @rithviknishad

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

Screenshots

  • Before:
    before

  • After:

after

@sachdevavaibhav sachdevavaibhav requested a review from a team May 30, 2023 13:31
@sachdevavaibhav sachdevavaibhav requested a review from a team as a code owner May 30, 2023 13:31
@vercel
Copy link

vercel bot commented May 30, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 5, 2023 8:00am

@netlify
Copy link

netlify bot commented May 30, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit bef6619
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/647f3a0627e2d50008858887
😎 Deploy Preview https://deploy-preview-5570--care-egov-staging.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

rithviknishad
rithviknishad requested changes May 30, 2023
View reviewed changes
src/Components/Facility/BedDeleteDialog.tsx Outdated Show resolved Hide resolved
src/Components/Facility/BedDeleteDialog.tsx Outdated Show resolved Hide resolved
@sachdevavaibhav
Copy link
Contributor Author

Screenshot 2023-05-30 221859

@rithviknishad Kindly review the changes.

@nihal467
Copy link
Member

nihal467 commented Jun 5, 2023

LGTM

@vercel
Copy link

vercel bot commented Jun 6, 2023

@khavinshankar is attempting to deploy a commit to the Coronasafe Team on Vercel.

A member of the Team first needs to authorize it.

@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khavinshankar khavinshankar merged commit 24fa730 into coronasafe:develop Jun 7, 2023
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rithviknishad rithviknishad rithviknishad approved these changes

@khavinshankar khavinshankar khavinshankar approved these changes

@vigneshhari vigneshhari Awaiting requested review from vigneshhari

Assignees
No one assigned
Labels
tested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Material UI components in src/Components/Facility/BedDeleteDialog.tsx:
4 participants
@sachdevavaibhav @nihal467 @rithviknishad @khavinshankar