Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make buttons full width in mobile view #5576

Closed
wants to merge 1 commit into from
Closed

Make buttons full width in mobile view #5576

wants to merge 1 commit into from

Conversation

Pranshu1902
Copy link
Contributor

@Pranshu1902 Pranshu1902 commented May 31, 2023 •
edited by ghost
Loading

Proposed Changes

@coronasafe/care-fe-code-reviewers @coronasafe/code-reviewers

Merge Checklist

  • Add specs that demonstrate bug / test a new feature.
  • Update product documentation.
  • Ensure that UI text is kept in I18n files.
  • Prep screenshot or demo video for changelog entry, and attach it to issue.
  • Request for Peer Reviews
  • Completion of QA

HOW

🤖 Generated by Copilot at 528a136

  • Make file upload and camera buttons responsive and consistent by adding w-full md:w-auto class to their label and ButtonV2 elements (link, link, link) in FileUpload.tsx

@Pranshu1902 Pranshu1902 requested a review from a team May 31, 2023 19:47
@Pranshu1902 Pranshu1902 requested a review from a team as a code owner May 31, 2023 19:47
@Pranshu1902 Pranshu1902 requested a review from gigincg May 31, 2023 19:47
@vercel
Copy link

vercel bot commented May 31, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
care-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 31, 2023 7:48pm

@netlify
Copy link

netlify bot commented May 31, 2023 •
edited
Loading

✅ Deploy Preview for care-egov-staging ready!

Name Link
🔨 Latest commit 528a136
🔍 Latest deploy log https://app.netlify.com/sites/care-egov-staging/deploys/6477a467f01e7c0008289f09
😎 Deploy Preview https://deploy-preview-5576--care-egov-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@sonarcloud
Copy link

sonarcloud bot commented May 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@patelaryan7751
Copy link
Contributor

hey @Pranshu1902 #5540 would solve the problem altogether as there is only a single file upload component on both the pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gigincg gigincg Awaiting requested review from gigincg

Assignees
No one assigned
Labels
needs testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make buttons full width in mobile view on samples page
2 participants
@Pranshu1902 @patelaryan7751